Chore: Fix fullscreen nav and hide toggle thumbnail button #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @ConradJChan has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Feb 14, 2019
| @@ -149,6 +149,7 @@ $header-height: 48px; | |||
| align-items: center; | |||
| display: flex; | |||
| flex: 1 1 auto; | |||
There was a problem hiding this comment.
Does it make sense to set the flex-basis to 100%, instead or as well?
There was a problem hiding this comment.
I tried that but Safari doesn't seem to care about that value either
jstoffan
approved these changes
Feb 14, 2019
ConradJChan
pushed a commit
to ConradJChan/box-content-preview
that referenced
this pull request
Feb 19, 2019
Also fixes an issue where elements that request fullscreen in Safari do not get their width set appropriately if it is a flex item in a flex container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min-widthto the.bp-contentdiv so that fullscreen works in Safari