Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discoverability): set mode to REGION on escape key press #1263

Merged
merged 7 commits into from
Sep 24, 2020
Merged

fix(discoverability): set mode to REGION on escape key press #1263

merged 7 commits into from
Sep 24, 2020

Conversation

ChenCodes
Copy link
Contributor

@ChenCodes ChenCodes commented Sep 22, 2020 •
edited
Loading

ezgif com-video-to-gif (8)

@ChenCodes ChenCodes marked this pull request as ready for review September 23, 2020 16:57
@ChenCodes ChenCodes requested a review from a team as a code owner September 23, 2020 16:57
@ChenCodes ChenCodes mentioned this pull request Sep 23, 2020
Merged
@mxiao6
Copy link
Contributor

mxiao6 commented Sep 23, 2020

Looks good to me besides tests.

@mergify mergify bot merged commit e72a7c7 into box:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@mxiao6 mxiao6 mxiao6 approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenCodes @mxiao6 @ConradJChan