fix(discoverability): click incorrectly toggles region creator mode #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add unit tests |
mxiao6
reviewed
Sep 24, 2020
ConradJChan
reviewed
Sep 24, 2020
ChenCodes
commented
Sep 25, 2020
mxiao6
reviewed
Sep 25, 2020
ChenCodes
commented
Sep 25, 2020
mxiao6
reviewed
Sep 25, 2020
ConradJChan
reviewed
Sep 25, 2020
jstoffan
reviewed
Sep 26, 2020
jstoffan
reviewed
Sep 26, 2020
ChenCodes
force-pushed
the
click-toggles-region-creator-mode
branch
from
aee9f88 to
90b4253
Compare
ChenCodes
commented
Sep 28, 2020
mxiao6
reviewed
Sep 28, 2020
ConradJChan
reviewed
Sep 28, 2020
mxiao6
reviewed
Sep 28, 2020
mxiao6
previously approved these changes
Sep 28, 2020
ChenCodes
force-pushed
the
click-toggles-region-creator-mode
branch
from
10b6d48 to
c37abb5
Compare
mxiao6
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue:
When the user clicks down on a region area,
handleStartis being called which causes the Region button to be toggled on. However, when they let go of the button, handleStop is not being fired.Solution:
We will call handleAbort in handleStop if the shape is null. handleAbort will call
resetCreatorwhich should emit thecancelevent that the FSM in Preview SDK will consume.Demo:
