Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add escape hotkey on AnnotationPopover #327

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Conversation

pramodsum
Copy link
Contributor

@pramodsum pramodsum commented Jan 24, 2019

Updated version of #248

  • Test in IE/Edge/mobile (confirm there's no focus trap which will prevent highlighting)
  • Update tests

@boxcla
Copy link

boxcla commented Jan 24, 2019

Verified that @pramodsum has signed the CLA. Thanks for the pull request!

src/components/AnnotationPopover/AnnotationPopover.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@pramodsum pramodsum merged commit e92ec85 into box:master Jan 25, 2019
pramodsum added a commit to JustinHoldstock/box-content-preview that referenced this pull request Jan 25, 2019
https://github.com/box/box-annotations/releases/tag/v3.7.1

* Update Translations (box#328) ([39805b8](box/box-annotations@39805b8)), closes [box#328](box/box-annotations#328)
* Chore: Add escape hotkey on AnnotationPopover (box#327) ([e92ec85](box/box-annotations@e92ec85)), closes [box#327](box/box-annotations#327)
* Fix: Highlight selection on Surface (box#326) ([6a3b83a](box/box-annotations@6a3b83a)), closes [box#326](box/box-annotations#326)
* Fix: Import correct styling for flyout component (box#325) ([14d65f6](box/box-annotations@14d65f6)), closes [box#325](box/box-annotations#325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants