Fix: Highlight selection on Surface #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not reset highlight selection on 'selectionchange' event on touch enabled devices when the user is creating a highlight annotation
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
requested review from
ConradJChan,
JustinHoldstock,
jstoffan,
jeremypress and
DanDeMicco
pramodsum
commented
Jan 24, 2019
|
|
||
| // Do nothing if in a text area or mobile dialog or mobile create dialog is already open | ||
| const pointController = this.modeControllers[TYPES.point]; | ||
| const isCreatingPoint = !!(pointController && pointController.pendingThreadID); | ||
| const isPopoverActive = !!util.findClosestElWithClass(document.activeElement, CLASS_ANNOTATION_POPOVER); | ||
| if (this.isCreatingHighlight || isCreatingPoint || isPopoverActive) { |
There was a problem hiding this comment.
Should re-show the create dialog on selection change so that the position updates
| @@ -577,7 +579,7 @@ class DocAnnotator extends Annotator { | |||
| } | |||
|
|
|||
| this.selectionEndTimeout = setTimeout(() => { | |||
| if (this.createHighlightDialog && !this.createHighlightDialog.isVisible) { | |||
There was a problem hiding this comment.
Ensures create dialog is re-positioned on timeout
jeremypress
reviewed
Jan 24, 2019
jeremypress
reviewed
Jan 24, 2019
jeremypress
previously approved these changes
Jan 25, 2019
jeremypress
approved these changes
Jan 25, 2019
pramodsum
added a commit
to JustinHoldstock/box-content-preview
that referenced
this pull request
Jan 25, 2019
https://github.com/box/box-annotations/releases/tag/v3.7.1 * Update Translations (box#328) ([39805b8](box/box-annotations@39805b8)), closes [box#328](box/box-annotations#328) * Chore: Add escape hotkey on AnnotationPopover (box#327) ([e92ec85](box/box-annotations@e92ec85)), closes [box#327](box/box-annotations#327) * Fix: Highlight selection on Surface (box#326) ([6a3b83a](box/box-annotations@6a3b83a)), closes [box#326](box/box-annotations#326) * Fix: Import correct styling for flyout component (box#325) ([14d65f6](box/box-annotations@14d65f6)), closes [box#325](box/box-annotations#325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only reset highlight selection on
selectionchangeevent on touch enabled devices when the user is NOT creating a highlight annotationtests