Fix: Only show create dialog when creating new point annotations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pramodsum
commented
Oct 12, 2017
•
pramodsum
commented
jeremypress
reviewed
Oct 16, 2017
| @@ -231,6 +239,16 @@ class Annotator extends EventEmitter { | |||
| </div>`.trim(); | |||
|
|
|||
| this.container.appendChild(mobileDialogEl); | |||
|
|
|||
| if (this.isModeAnnotatable(TYPES.point)) { | |||
| this.createPointDialog = new CreateAnnotationDialog(this.container, { | |||
| * Events emitted by this component. | ||
| * TODO(@spramod): Evaluate if these events need to be propogated to viewer | ||
| */ | ||
| export const CreateEvents = { |
| @@ -0,0 +1,270 @@ | |||
| import EventEmitter from 'events'; | |||
There was a problem hiding this comment.
Does this fit in with our future model of using modes/controllers?
There was a problem hiding this comment.
This fits in with that, because this is a shared point annotation creation dialog. Right now this is just for desktop but ideally we would be just triggering this dialog w/o creating a thread for both mobile and desktop.
JustinHoldstock
approved these changes
Oct 17, 2017
| /** @property {HTMLElement} - The parent container to nest the dialog element in. */ | ||
| parentEl; | ||
|
|
||
| /** @property {HTMLElement} - The element containing the buttons that can creaet highlights. */ |
There was a problem hiding this comment.
Typo!
creaet -> create
| @@ -0,0 +1,270 @@ | |||
| import EventEmitter from 'events'; | |||
pramodsum
force-pushed
the
master
branch
4 times, most recently
from
be1f03a to
3fdeabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.