Fix: Only show create dialog when creating new point annotations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodsum
force-pushed
the
bugs
branch
4 times, most recently
from
d799660 to
7dcae58
Compare
JustinHoldstock
approved these changes
Nov 14, 2017
jeremypress
reviewed
Nov 14, 2017
| @@ -149,7 +149,7 @@ class DrawingModeController extends AnnotationModeController { | |||
| * @return {void} | |||
| */ | |||
| bindDOMListeners() { | |||
| if (this.isTouchCompatible) { | |||
| if (this.isMobile && this.hasTouch) { | |||
| this.annotatedElement.addEventListener('touchstart', this.handleSelection); | |||
There was a problem hiding this comment.
what if you're on a desktop browser that has touch like a surface?
There was a problem hiding this comment.
Made a ticket to clarify these checks
| this.createDialog.addListener(CREATE_EVENT.init, () => this.emit(THREAD_EVENT.pending, TYPES.point)); | ||
|
|
||
| this.createDialog.addListener(CREATE_EVENT.cancel, () => { | ||
| const thread = this.getThreadByID(this.pendingThreadID); |
There was a problem hiding this comment.
break these out into testable functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR comments #3 that was auto-closed by Github