Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PHP 8 support #508

Merged
merged 8 commits into from
Dec 18, 2020
Merged

add PHP 8 support #508

merged 8 commits into from
Dec 18, 2020

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Dec 3, 2020 •
edited
Loading

resolves #486

@smoench smoench force-pushed the php8 branch 6 times, most recently from 219538f to 22742ae Compare December 4, 2020 13:27
@smoench smoench mentioned this pull request Dec 4, 2020
Merged
villfa
villfa reviewed Dec 4, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@villfa
Copy link
Contributor

villfa commented Dec 7, 2020

The current error is related to hoaproject/Stream#30

@smoench
Copy link
Contributor Author

smoench commented Dec 7, 2020

Yes, what should we do with the hoa dependencies? Can be https://github.com/phpstan/phpdoc-parser used instead?

@villfa
Copy link
Contributor

villfa commented Dec 7, 2020 •
edited
Loading

phpDocumentor/ReflectionDocBlock seems to be also a good candidate.

The PHPStan's parser has the advantage to be dependency-free.

@theofidry
Copy link
Member

I don't have a strong opinion about which solution we use, so I would say whichever is the easiest

@smoench
Copy link
Contributor Author

smoench commented Dec 8, 2020

phpDocumentor/ReflectionDocBlock looks promising #511. phpstan/phpdoc-parser has some issues parsing multiline annotations.

@smoench smoench mentioned this pull request Dec 14, 2020
Merged
@villfa
Copy link
Contributor

villfa commented Dec 15, 2020

FYI from PHP 8 the generated name of the anonymous classes have changed: php/php-src#5153
It explains why some tests fail.

@smoench
Copy link
Contributor Author

smoench commented Dec 15, 2020

I have reworked the build workflow to run tests in parallel

@smoench
Copy link
Contributor Author

smoench commented Dec 15, 2020

The behavior of tokenizer extension has changed with PHP 8.0 -> https://3v4l.org/QdDvZ

@smoench smoench force-pushed the php8 branch 4 times, most recently from 42d667b to 00d2f96 Compare December 17, 2020 14:45
@smoench smoench force-pushed the php8 branch 3 times, most recently from bf27b0b to d213515 Compare December 17, 2020 15:02
@smoench smoench marked this pull request as ready for review December 18, 2020 09:25
@smoench
Copy link
Contributor Author

smoench commented Dec 18, 2020

Ready for review :-)

@theofidry theofidry merged commit 3387777 into box-project:master Dec 18, 2020
@theofidry
Copy link
Member

Thanks a lot for the PR! 👏

@theofidry
Copy link
Member

If you can do another PR where we dump the requirement checker I'll do a release ASAP; otherwise I'll do that tonight

@smoench smoench deleted the php8 branch December 18, 2020 14:18
@smoench
Copy link
Contributor Author

smoench commented Dec 18, 2020

@theofidry here you go #515

@Pen-y-Fan Pen-y-Fan mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villfa villfa villfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PHP8
3 participants
@smoench @villfa @theofidry