Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the tools with exclude-php:8.0 tag #357

Closed
Pen-y-Fan opened this issue Feb 23, 2021 · 8 comments · Fixed by #431
Closed

Check the tools with exclude-php:8.0 tag #357

Pen-y-Fan opened this issue Feb 23, 2021 · 8 comments · Fixed by #431

Comments

@Pen-y-Fan
Copy link
Contributor

Pen-y-Fan commented Feb 23, 2021

There are 16 tools with exclude-php:8.0 tag.

Each repo has been checked, to create this plan

Name Excluded from PHP 8.0 Comments Worth a Try?
analyze Last PR 4 Dec 2019. Forked project also has no recent activity
box Add PHP 8 support (#508)
diffFilter Last PR Oct 2020, composer.json shows "php": ">=7.0",
doctrine-psalm-plugin composer.json showing "php": ".. ^8",
parallel-lint README updated 15 Mar 2020 to advise This repository is abandoned. Suggested alternative: https://github.com/php-parallel-lint/PHP-Parallel-Lint > readme states This works from PHP 5.4 to 7.4
paratest Last PR 5 days ago, composer.json "php": " .. ^8.0",
php-coupling-detector Last PR 4 Jan 2021 to add PHP 8 #62, composer.json "php": ">=7.2",
php-formatter Last PR 31 Dec 2017.
phpat Last PR 28 Dec 2020. composer.json "php": "^7.2",
phpDocumentor Last PR 22 Feb 2021 (Yesterday). composer.json "php": "... ^8.0",
phpinsights Last PR 9 days ago (14 Feb 2021) composer.json "php": ".. ^8.0",
phpmnd Last PR 27 days ago (25 Jan 2021) composer.json "php": "^7.1",
phpunit-5 Last PR for 5.7.27 was 1 Feb 2018
phpunit-7 composer.json for 7.5.20 locked at "php": "^7.1",, a fork used by Silverstripe may work: sminnee/phpunit
rector Last PR today 23 Feb 2021. php: .. ^8.0
roave-backward-compatibility-check Last PR 5 days ago (18 Feb 2021), composer.json "php": "^7.4.7",

Summary

  • ✅ 7 worth a try
  • ❌ 8 no activity or locked to PHP 7
  • ❓ 1 is possible by using a fork.

The next step is to remove the tag and see if the build passes.

Edit: php-formatter should be ❌

@Pen-y-Fan
Copy link
Contributor Author

Summary:

  • 4 passed: box, doctrine-psalm-plugin, php-coupling-detector & rector
  • 3 failed: paratest, phpDocumentor & phpinsights

@Pen-y-Fan
Copy link
Contributor Author

Pen-y-Fan commented Feb 23, 2021

paratest has released v6,2,0, but not as a phar file, possibly it can be installed from the github repo. composer require --dev brianium/paratest

phpDocumentor has a dev-master / 3.0.x-dev branch with PHP ^8.0. PHP 8 tests are passing, it is Scrutinizer that failed.

phpinsights has dev-master branch with PHP ^8.0

@Pen-y-Fan
Copy link
Contributor Author

phpunit-7 is available via composer require sminnee/phpunit I can't see a phar version.

sminnee is the CEO of Silverstripe, who supply the Silverstripe CMS to the New Zealand government.

@jakzal
Copy link
Owner

jakzal commented Feb 24, 2021

Great work!

@jakzal
Copy link
Owner

jakzal commented Feb 24, 2021

phpunit-7 is available via composer require sminnee/phpunit I can't see a phar version.

Since newer versions of phpunit are there, I don't think we need to worry about phpunit-7.

@jakzal
Copy link
Owner

jakzal commented Nov 30, 2021

We need to re-evaluate the list. I only quickly looked at a few packages and rebased/merged some PRs.

From what I looked at:

@carlosas
Copy link
Contributor

@jakzal regarding phpat: PHP 8 compatibility fully released https://github.com/carlosas/phpat/releases/tag/0.8.0 🙂

@jakzal
Copy link
Owner

jakzal commented Dec 20, 2021

Thanks @carlosas

#410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants