Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if filename contains slash #188

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Throw exception if filename contains slash #188

merged 2 commits into from
Apr 24, 2019

Conversation

bizurkur
Copy link
Contributor

@bizurkur bizurkur requested a review from a team April 23, 2019 01:47
@allejo
Copy link
Member

allejo commented Apr 23, 2019

While we're on the topic of blacklisted characters in filenames... Should there be an array of blacklisted characters instead? I know : is a forbidden character at least on macOS and I think on Windows too.

@bizurkur
Copy link
Contributor Author

As for other blacklisted characters, that sounds like something that should be done as a separate PR to me but possibly a good idea. I think the point of this issue was that allowing / gave the interpretation that it would automatically create a directory containing a file and that's not what happens.

CHANGELOG.md Outdated Show resolved Hide resolved
@mikey179 mikey179 self-requested a review April 24, 2019 08:43
@bizurkur bizurkur merged commit b46b9df into bovigo:master Apr 24, 2019
@bizurkur bizurkur deleted the no-slash-in-filename branch March 4, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vfsStream::newFile allows slashes in filenames
3 participants