Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception with invalid characters #191

Open
allejo opened this issue Jul 23, 2019 · 2 comments
Open

Throw exception with invalid characters #191

allejo opened this issue Jul 23, 2019 · 2 comments

Comments

@allejo
Copy link
Member

allejo commented Jul 23, 2019

Following up on #188 (comment), I propose we implement a blacklist of characters.

For example, / is now blacklisted after #188. But the : character is also invalid on macOS and Windows, not sure about Linux.

Are there any other characters that we should disallow in filenames and directory names?

@mikey179
Copy link
Member

I'm unsure about this. If we go down that route we might have to think about whether we want to disallow certain file extensions that are forbidden on Windows. Where would we draw the line on what is allowed and what isn't?

@bizurkur
Copy link
Contributor

If things were changed to accept a configuration object (or array), the idea of a blacklist could be part of the config - entirely dictated by the user. You could also use the idea of a config to set the directory separator, case-sensitivity, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants