Add support for sso-session credentials #2812
Conversation
nateprewitt
force-pushed
the
sso_tokens
branch
from
fdada5c to
673d59f
Compare
Codecov ReportBase: 93.45% // Head: 93.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2812 +/- ##
========================================
Coverage 93.45% 93.45%
========================================
Files 63 63
Lines 13298 13337 +39
========================================
+ Hits 12427 12464 +37
- Misses 871 873 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nateprewitt
force-pushed
the
sso_tokens
branch
2 times, most recently
from
79fb260 to
020cd4c
Compare
| with open(self.config_file, 'w') as f: | ||
| f.write(config) | ||
|
|
||
| def test_token_chosen_from_provider(self): |
There was a problem hiding this comment.
It would be great if we added test cases for some of the error cases such as:
- Mismatching start url and sso region
- SSO session not being defined
I'm also wondering if we should add a case for having an expired SSO token in the cache and needing the token provider to refresh first. However, I'm not sure how straightforward that will be to add. Thoughts?
There was a problem hiding this comment.
The first two are super reasonable, I attempted the last one earlier but the MockCache gets very complicated to do this without the ability to change inputs.
nateprewitt
force-pushed
the
sso_tokens
branch
from
020cd4c to
694165a
Compare
The updates allow using sso-session configuration as part of the SSO credential provider. This was ported from this PR: boto/botocore#2812
The updates allow using sso-session configuration as part of the SSO credential provider. This was ported from this PR: boto/botocore#2812
This PR will add support for loading credentials via a configured
sso-sessionin your AWS config file.