Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Port SSO credential provider updates #7445

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

kyleknap
Copy link
Contributor

The updates allow using sso-session configuration as part of the SSO credential provider. This was ported from this PR: boto/botocore#2812. We will follow up with this PR in merging this PR: #7364 that allows for interactive configuration of SSO sessions and direct login with SSO sessions.

The updates allow using sso-session configuration as part of
the SSO credential provider. This was ported from this PR:
boto/botocore#2812
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

Codecov Report

Merging #7445 (0ca979c) into v2 (8fef0ef) will decrease coverage by 0.14%.
The diff coverage is 91.20%.

@@            Coverage Diff             @@
##               v2    #7445      +/-   ##
==========================================
- Coverage   93.71%   93.56%   -0.15%     
==========================================
  Files         351      351              
  Lines       36177    36203      +26     
  Branches     5203     5212       +9     
==========================================
- Hits        33903    33875      -28     
- Misses       1649     1684      +35     
- Partials      625      644      +19     
Impacted Files Coverage Δ
awscli/botocore/utils.py 94.57% <82.97%> (-0.66%) ⬇️
awscli/botocore/credentials.py 97.08% <100.00%> (-0.42%) ⬇️
awscli/botocore/tokens.py 83.87% <100.00%> (+0.53%) ⬆️
awscli/s3transfer/compat.py 71.05% <0.00%> (-15.79%) ⬇️
awscli/customizations/s3/comparator.py 95.31% <0.00%> (-4.69%) ⬇️
awscli/compat.py 59.18% <0.00%> (-4.09%) ⬇️
awscli/s3transfer/tasks.py 91.66% <0.00%> (-3.34%) ⬇️
awscli/botocore/compat.py 91.30% <0.00%> (-2.18%) ⬇️
awscli/help.py 95.02% <0.00%> (-1.02%) ⬇️
awscli/customizations/codedeploy/push.py 91.00% <0.00%> (-1.00%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kyleknap kyleknap merged commit 6a7280e into aws:v2 Nov 16, 2022
@kyleknap kyleknap deleted the v2-update-sso-cred-provider branch November 16, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants