Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress pyopenssl deprecation warning with catch_warnings #2763

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

dlm6693
Copy link
Contributor

@dlm6693 dlm6693 commented Sep 19, 2022

This addresses #2744. It does so by suppressing all warnings of type DeprecationWarning when attempting to import from pyOpenSSL

@dlm6693 dlm6693 requested a review from nateprewitt September 19, 2022 20:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 95.25% // Head: 95.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c05b328) compared to base (3b08f37).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2763   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files           62       62           
  Lines        12896    12899    +3     
========================================
+ Hits         12284    12287    +3     
  Misses         612      612           
Impacted Files Coverage Δ
botocore/httpsession.py 91.82% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick change to clarify why this is being added, otherwise, looks good!

botocore/httpsession.py Show resolved Hide resolved
@dlm6693 dlm6693 force-pushed the suppress-urllib3-deprecation-warning branch from 6154222 to c05b328 Compare September 22, 2022 20:54
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlm6693 dlm6693 merged commit 87eba48 into boto:develop Sep 22, 2022
@dlm6693 dlm6693 deleted the suppress-urllib3-deprecation-warning branch September 22, 2022 22:05
aws-sdk-python-automation added a commit that referenced this pull request Sep 23, 2022
* release-1.27.80:
  Bumping version to 1.27.80
  Update to latest endpoints
  Update to latest models
  suppress pyopenssl deprecation warning with catch_warnings (#2763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants