Import fails with -Werror python option

[headtr1ck]

Describe the bug

When importing botocore.session with the python option -Werror the import fails.

Expected Behavior

Import works

Current Behavior

The import raises:

E DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated and will be removed in a future release of urllib3 2.x. Read more in this issue: urllib3/urllib3#2680

Reproduction Steps

python -Werror -c "import botocore.session"

Possible Solution

In line:

botocore/botocore/httpsession.py

Line 35 in dfda41c

except ImportError:

add DeprecationWarning to the excepted Errors.

Additional Information/Context

See pydata/xarray#7322 which run into this problem.

SDK version used

1.27.59

Environment details (OS name and version, etc.)

Win10/linux

[tim-finnigan]

Hi @headtr1ck thanks for reaching out. This issue was previously reported here: #2744. You can refer to the discussion there for more context as well as the corresponding PR (#2763) for suppressing the warning. Please let us know if you had any follow up questions after reviewing the comments there.

[headtr1ck]

Thanks for pointing out that issue. Unfortunately in my case the solution of this PR does not work since no warning is issued when using -Werror but an error is raised.

So adding the DeprecationWarning to the expect block is the only thing that would help.

[tim-finnigan]

Do you see that error on the latest version of boto3/botocore?

[github-actions]

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.