ConnectionTask: Fix request failure retrying #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if the request failed after X number of attempts this would throw an Exception which would not be caught in the ConnectionTask. Instead the request should be continuously retried until the request was successful or until the BanManager bans the node. Fixes bosagora#1105
AndrejMitrovic
added
the
type-bug
Geod24
reviewed
Aug 7, 2020
The per-request timeout is too high. The waitForDiscovery() call in the integration test only waited 5 seconds, but this doesn't give us enough time to attempt a request again.
|
The CI still failed so I'm trying another thing in a second commit. |
But the "uncaught exception" errors are now gone so this is good. |
Codecov Report
@@ Coverage Diff @@
## v0.x.x #1106 +/- ##
==========================================
+ Coverage 77.30% 78.55% +1.25%
==========================================
Files 81 83 +2
Lines 7886 7912 +26
==========================================
+ Hits 6096 6215 +119
+ Misses 1790 1697 -93
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Geod24
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might resolve the frequent CircleCI failures we've seen recently.
Fixes #1105