Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionTask is not handling request timeouts gracefully #1105

Closed
AndrejMitrovic opened this issue Aug 7, 2020 · 0 comments · Fixed by #1106
Closed

ConnectionTask is not handling request timeouts gracefully #1105

AndrejMitrovic opened this issue Aug 7, 2020 · 0 comments · Fixed by #1106
Assignees
@AndrejMitrovic
Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Milestone
2. Validator

Comments

@AndrejMitrovic
Copy link
Contributor

https://github.com/bpfkorea/agora/blob/ef0b8e70fb4a2afef110dc960f998b6d1ec1a9ec/source/agora/network/NetworkManager.d#L162

This code can throw an Exception (in NetworkClient) which will not be caught by the try/catch.

I have a fix for it, but I need to write a test-case.
@AndrejMitrovic AndrejMitrovic added the type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense label Aug 7, 2020
@AndrejMitrovic AndrejMitrovic self-assigned this Aug 7, 2020
@AndrejMitrovic AndrejMitrovic added this to the 2. Validator milestone Aug 7, 2020
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 7, 2020
@AndrejMitrovic
ConnectionTask: Fix request failure retrying
bd07dc4 
Previously if the request failed after X number of
attempts this would throw an Exception which would
not be caught in the ConnectionTask.

Instead the request should be continuously retried
until the request was successful or until the
BanManager bans the node.

Fixes bosagora#1105
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Aug 7, 2020
@AndrejMitrovic
ConnectionTask: Fix request failure retrying
ae6e79c 
Previously if the request failed after X number of
attempts this would throw an Exception which would
not be caught in the ConnectionTask.

Instead the request should be continuously retried
until the request was successful or until the
BanManager bans the node.

Fixes bosagora#1105
@AndrejMitrovic AndrejMitrovic mentioned this issue Aug 7, 2020
Merged
Geod24 pushed a commit that referenced this issue Aug 7, 2020
@AndrejMitrovic @Geod24
ConnectionTask: Fix request failure retrying
d5f011c 
Previously if the request failed after X number of
attempts this would throw an Exception which would
not be caught in the ConnectionTask.

Instead the request should be continuously retried
until the request was successful or until the
BanManager bans the node.

Fixes #1105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrejMitrovic AndrejMitrovic

Labels
type-bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Milestone
2. Validator
Development

Successfully merging a pull request may close this issue.

ConnectionTask: Fix request failure retrying AndrejMitrovic/agora
1 participant
@AndrejMitrovic