Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run unit tests on multiple node versions #1142

Closed
wants to merge 2 commits into from
Closed

chore: run unit tests on multiple node versions #1142

wants to merge 2 commits into from

Conversation

spnraju
Copy link

@spnraju spnraju commented Jul 19, 2022

Description

Fixes #1118 : updating GitHub workflow to run unit tests on multiple versions (14, 16, and 18) of nodejs

Changes

Added a matrix to Github actions for unit tests. This helps in running tests on multiple Nodejs versions.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@NickSeagull
Copy link
Member

Woah thanks for this! Let's see how well it fares against multiple versions 😅

@spnraju spnraju closed this Sep 10, 2022
@spnraju spnraju reopened this Sep 10, 2022
@ghost
Copy link

ghost commented Sep 10, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@NickSeagull
Copy link
Member

Hello @spnraju , we're currently moving a lot of stuff in the 1.0.0 branch, mainly switching build tools. This PR hasn't been merged because it'd make all PRs to fail to merge, and for now everything (at least) works in 16.

As soon as 1.0.0 gets merged, we'll take action on this PR and make sure it builds with all node versions. Thanks a lot!

@javiertoledo
Copy link
Member

This PR would need to be reworked as we've migrated to MS Rush since it was opened. I'll close it and let @NickSeagull decide the next steps, as he's currently reworking the CI/CD processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD: Ensure all Node.js versions are supported
3 participants