Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Ensure all Node.js versions are supported #1118

Open
NickSeagull opened this issue Jun 27, 2022 · 0 comments · May be fixed by #1440
Open

CI/CD: Ensure all Node.js versions are supported #1118

NickSeagull opened this issue Jun 27, 2022 · 0 comments · May be fixed by #1440
Labels
bug Something isn't working difficulty: low good first issue Good for newcomers priority: medium size: M Tasks where you have to change some files.

Comments

@NickSeagull
Copy link
Member

NickSeagull commented Jun 27, 2022

Bug Report

Current Behavior

There are times that unit tests fail on some Node.js versions. For example, CLI tests that check for environment variables complain on Node.js v18 and other multiple ones. I only managed to run the tests properly on v16.14.2

Expected behavior

We should support a specific number of Node.js versions, unit tests should pass on all of them equally. This behavior should be working on the latest minor version of the major versions we support.

E.g. if we support v18, v16 and v14, the CI/CD process should work on the latest versions of those.

Possible Solution

Modify the GitHub actions workflows so unit tests are run on the versions of Node.js we support

@NickSeagull NickSeagull added bug Something isn't working good first issue Good for newcomers size: M Tasks where you have to change some files. difficulty: low priority: medium labels Jun 27, 2022
@rishabh1S rishabh1S linked a pull request Sep 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty: low good first issue Good for newcomers priority: medium size: M Tasks where you have to change some files.
Projects
None yet
1 participant