Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: class-validator & class-transformer 적용 #50

Merged
merged 2 commits into from
Nov 21, 2022
Merged

feat: class-validator & class-transformer 적용 #50

merged 2 commits into from
Nov 21, 2022

Conversation

June1010
Copy link
Member

Feature

  • 배경
    • 커스텀 검증 로직을 적용할 수 있는 데코레이터 필요
  • 목적
    • Dto에 적용할 커스텀 데코레이터 구현 & 적용
    • 기존 컨트롤러에서 plaintoClass 하던 로직을 pipe에 위임

과정

  • 커스텀 데코레이터 생성
  • Validation Pipe 적용

결과 (스크린샷 등)

스크린샷 2022-11-21 오전 11 48 04

관련 issue 번호 (링크)

#44

테스트 방법

Postman

Commit

@June1010 June1010 self-assigned this Nov 21, 2022
gchoi96
gchoi96 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@gchoi96 gchoi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pushedrumex
pushedrumex approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@pushedrumex pushedrumex merged commit 28d37c9 into develop Nov 21, 2022
@gchoi96 gchoi96 deleted the feat/validation branch November 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pushedrumex pushedrumex pushedrumex approved these changes

@gchoi96 gchoi96 gchoi96 approved these changes

@claycat claycat Awaiting requested review from claycat

Assignees

@June1010 June1010

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@June1010 @gchoi96 @pushedrumex