Merge pull request #50 from boostcampwm-2022/feat/validation

feat: class-validator & class-transformer 적용

server/src/common/decorator/id.validator.ts

@@ -0,0 +1,32 @@
+import {
+    registerDecorator,
+    ValidationOptions,
+    ValidatorConstraint,
+    ValidatorConstraintInterface,
+} from "class-validator";
+
+@ValidatorConstraint({ name: "isValidId", async: false })
+class isValidIdConstraint implements ValidatorConstraintInterface {
+    public validate(value: string) {
+        return (
+            typeof value === "string" && value.length >= 6 && value.length <= 20 && value.search(/^[a-zA-Z0-9]*$/) >= 0
+        );
+    }
+
+    public defaultMessage(): string {
+        return `user id must be between 6 and 20 character long, only letters and numbers allowed`;
+    }
+}
+
+export function IsValidId(validationOptions?: ValidationOptions) {
+    return function (object: any, propertyName: string) {
+        registerDecorator({
+            name: "isValidId",
+            target: object.constructor,
+            propertyName: propertyName,
+            constraints: [],
+            options: validationOptions,
+            validator: isValidIdConstraint,
+        });
+    };
+}

server/src/common/decorator/index.ts

@@ -0,0 +1,4 @@
+import { IsValidId } from "./id.validator";
+import { IsValidPassword } from "./pw.validator";
+
+export { IsValidId, IsValidPassword };

server/src/common/decorator/pw.validator.ts

@@ -0,0 +1,30 @@
+import {
+    registerDecorator,
+    ValidationOptions,
+    ValidatorConstraint,
+    ValidatorConstraintInterface,
+} from "class-validator";
+
+@ValidatorConstraint({ name: "isValidPassword", async: false })
+class isValidPwConstraint implements ValidatorConstraintInterface {
+    public validate(value: string) {
+        return typeof value === "string" && value.length >= 10 && value.length <= 100;
+    }
+
+    public defaultMessage(): string {
+        return `user password must be between 10 and 100 character long`;
+    }
+}
+
+export function IsValidPassword(validationOptions?: ValidationOptions) {
+    return function (object: any, propertyName: string) {
+        registerDecorator({
+            name: "isValidPassword",
+            target: object.constructor,
+            propertyName: propertyName,
+            constraints: [],
+            options: validationOptions,
+            validator: isValidPwConstraint,
+        });
+    };
+}

server/src/main.ts

@@ -2,6 +2,7 @@ import { NestFactory } from "@nestjs/core";
 import { SwaggerModule, DocumentBuilder } from "@nestjs/swagger";
 import { AppModule } from "./app.module";
 import * as cookieParser from "cookie-parser";
+import { ValidationPipe } from "@nestjs/common";
 
 async function bootstrap() {
     const app = await NestFactory.create(AppModule);
@@ -14,6 +15,12 @@ async function bootstrap() {
     const document = SwaggerModule.createDocument(app, options);
     app.enableCors({ origin: true, methods: "GET,HEAD,PUT,PATCH,POST,DELETE,OPTIONS", credentials: true });
     app.use(cookieParser());
+    app.useGlobalPipes(
+        new ValidationPipe({
+            forbidUnknownValues: true,
+            transform: true,
+        }),
+    );
     SwaggerModule.setup("api", app, document);
 
     await app.listen(4000);

server/src/user/dto/create-user.dto.ts

@@ -1,12 +1,20 @@
-import { IsString, MinLength } from "class-validator";
+import { Type } from "class-transformer";
+import { IsNumber, IsNumberString } from "class-validator";
+import { IsValidId, IsValidPassword } from "src/common/decorator";
 import { User } from "../../entities/user.entity";
 
 export class CreateUserDto {
-    @IsString()
-    @MinLength(6)
+    @IsValidId()
     private userId: string;
+
+    @IsValidPassword()
     private password: string;
+
+    @Type(() => Number)
+    @IsNumber()
     private pace: number;
+
+    @IsNumberString()
     private zipCode: string;
 
     getUserId() {

server/src/user/user.controller.ts

@@ -9,7 +9,6 @@ export class UserController {
 
     @Post()
     async create(@Body() createUserDto: CreateUserDto) {
-        createUserDto = plainToClass(CreateUserDto, createUserDto);
         return this.userService.create(createUserDto);
     }
 }