Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignUp 페이지 오류 수정 #41

Merged
merged 3 commits into from
Nov 20, 2022
Merged

SignUp 페이지 오류 수정 #41

merged 3 commits into from
Nov 20, 2022

Conversation

gchoi96
Copy link
Member

@gchoi96 gchoi96 commented Nov 19, 2022

Fix

  • 배경
    • 회원가입 페이지에서 비밀번호와 비밀번호 확인만 채우면 나머지 필드들이 초기값이 없어도 제출 버튼이 작동하는 문제가 있었음
    • 모바일 화면에서 OptionWrapper의 레이아웃이 밀리는 문제가 있었음
  • 목적
    • 오류 수정

과정

input

  • useInput이 input 유효성 검사를 통과하지 못한 경우 value를 초기값으로 변경
  • form 유효성 검사에서 input value가 초기값인 경우 통과하지 못하도록 수정

OptionWrapper

  • Style 코드 수정

결과 (스크린샷 등)

관련 issue 번호 (링크)

테스트 방법

Commit

@gchoi96 gchoi96 self-assigned this Nov 19, 2022
Copy link
Member

@June1010 June1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:D

Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushedrumex pushedrumex merged commit 4a5ff71 into develop Nov 20, 2022
@gchoi96 gchoi96 deleted the fix/SignUpForm branch November 21, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants