Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useInput/InputValidator 버그 #34

Closed
claycat opened this issue Nov 18, 2022 · 1 comment
Closed

useInput/InputValidator 버그 #34

claycat opened this issue Nov 18, 2022 · 1 comment
Assignees
@claycat @gchoi96
Labels
bug Something isn't working frontend
Milestone
2주차

Comments

@claycat
Copy link
Collaborator

claycat commented Nov 18, 2022 •
edited
Loading

버그 설명

회원가입페이지에서 비밀번호와 비밀번호 확인만 채우면 나머지 필드들이 초기값이 없어도 제출버튼이 작동합니다

버그 상세 내용

회원가입페이지에서 비밀번호와 비밀번호 확인만 채우면 나머지 필드들이 초기값이 없어도 제출버튼이 작동합니다

재현 방법

  • 비밀번호와 비밀번호 확인란만 채우고 제출버튼 클릭

기대한 내용

  • validator에서 튕겨주기

발견된 내용

  • 제출성공

로그/스크린샷

녹화_2022_11_19_02_14_05_196

원인 및 해결 제안

  • useInput 훅에서 초기값을 에러로 바꿔야할것같습니다
  • 사실 DTO에서 체크해주긴할꺼같은데 이정도는 프론트에서 검증해주는게 맞다고 생각합니다
@claycat claycat added bug Something isn't working frontend labels Nov 18, 2022
@claycat claycat self-assigned this Nov 18, 2022
@gchoi96 gchoi96 self-assigned this Nov 19, 2022
@gchoi96
Copy link
Member

gchoi96 commented Nov 19, 2022

수정하겠습니다~~

gchoi96 added a commit that referenced this issue Nov 19, 2022
@gchoi96
fix: #34 Input에 값을 입력하지 않은 경우 체크하지 못하던 현상 수정
ce199b8
@gchoi96 gchoi96 mentioned this issue Nov 19, 2022
Merged
@gchoi96 gchoi96 added this to the 2주차 milestone Nov 19, 2022
@gchoi96 gchoi96 closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claycat claycat

@gchoi96 gchoi96

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
2주차
Development

No branches or pull requests
2 participants
@claycat @gchoi96