This repository has been archived by the owner on May 3, 2022. It is now read-only.
Upgrade client-go #104
Merged
Upgrade client-go #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanatohodets
previously approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Remove ~2,100,000 lines of code without a loss in functionality? Achievement unlocked!
Not sure how much review there is to do here beyond seeing that the tests pass and being a bit conservative in the rollout strategy, so LGTM. Many thanks for purging some of the old CI hacks.
Super nice work @parhamdoustdar and @juliogreff!
the new client-go interface requirements.
Now that we have moved to Go Modules, we no longer need to keep Gopkg files (dependencies are now managed by go.mod and go.sum), nor do we need to install and call `dep` in our CI pipeline. Instead, now we just call `go mod verify`, and ensure that all go commands use the vendored version of libraries by specifying `-mod=vendor`.
We can't really use modules in 1.10. Also, we have successfully ran shipper built with 1.12, so that's the reasonable thing to do.
Since hack/tools.go got introduced, trying to build /hack/ fails with: hack/tools.go:4:8:error: build constraints exclude all Go files in vendor/k8s.io/code-generator We could just add a build tag to make it compile, but there's not much of a gain there, so let's just skip it completely instead.
1. The kubernetes was only needed because of an older version of k8s.io/code-generator. Now that it's been upgraded, it's no longer needed. 2. kubectl is not needed since microk8s already installs a version of that. For convenience, we alias `kubectl` to `microk8s.kubectl`
client-go's fake dynamic client no longer contains actions from the non-dynamic client, so we had to split up, and sometimes join, lists of actions so they could be checked properly. With this, now all the unit tests pass with new client-go \o/
juliogreff
force-pushed
the
client-go-1.14.x
branch
from
2a49862
to
c1b3faf
Compare
|
Rebased against new master because of conflicts, should be able to merge cleanly now. |
kanatohodets
suggested changes
Jul 1, 2019
kanatohodets
approved these changes
Jul 1, 2019
osdrv
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93