Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Upgrade client-go #93

Closed
juliogreff opened this issue May 13, 2019 · 1 comment · Fixed by #104
Closed

Upgrade client-go #93

juliogreff opened this issue May 13, 2019 · 1 comment · Fixed by #104
Assignees
@parhamdoustdar
Milestone
release-0.5

Comments

@juliogreff
Copy link
Contributor

No description provided.

@juliogreff juliogreff added this to the release-0.5 milestone May 13, 2019
@ksurent
Copy link
Contributor

ksurent commented May 15, 2019

Relevant: https://github.com/bookingcom/shipper/tree/asurikov/kubernetes-1.11.4.
This is meant as the first step to bring client-go to something more up–to–date. There's an issue though. Modern client-go versions have a completely new dynamic client. There is also a backward compatibility layer in the form of the deprecated-dynamic package. The problem is that it does not have a corresponding fake package and that breaks tests.

@parhamdoustdar parhamdoustdar self-assigned this Jun 3, 2019
@juliogreff juliogreff mentioned this issue Jun 19, 2019
Merged
@osdrv osdrv closed this as completed in #104 Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@parhamdoustdar parhamdoustdar

Labels
None yet
Projects
None yet
Milestone
release-0.5
Development

Successfully merging a pull request may close this issue.

Upgrade client-go bookingcom/shipper
3 participants
@ksurent @juliogreff @parhamdoustdar