Increase default max number of significant digits for floating-point values in CsvWriter #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the default maximum number of significant digits when formatting floating-point values to ensure they can round-trip successfully using
CsvReaderor other applications.The formatting defaults of the General format specifier use G7 and G15 respectively as max precision defaults on .NET framework.
In the guidelines for using the Round-trip format specifier the recommendation is to use G9 and G17 respectively for maximum fidelity.
The defaults have been fixed in .NET Core 3.0 onwards, but we need the override until we move out of .NET framework.
Fixes #1260