Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log video metadata in Harp binary format #110

Closed
glopesdev opened this issue Feb 9, 2023 · 1 comment
Closed

Log video metadata in Harp binary format #110

glopesdev opened this issue Feb 9, 2023 · 1 comment
Labels
bug Something isn't working feature New planned feature quality control Data check to ensure integrity or quality of data
Milestone
0.3.0

Comments

@glopesdev
Copy link
Contributor

Currently the video metadata is saved in text CSV format, including Harp timestamp, frame counter and hardware frame counter. However, we have observed loss of precision in timestamp logging during this conversion in some epochs of the dataset.

It doesn't seem to affect alignment in practice, but since the values are not exactly matching due to rounding it makes it harder to stitch metadata and tracking datasets together (workaround is to use pd.merge_asof).
@glopesdev glopesdev added bug Something isn't working feature New planned feature quality control Data check to ensure integrity or quality of data labels Feb 9, 2023
@glopesdev glopesdev added this to the 0.3.0 milestone Feb 9, 2023
@glopesdev
Copy link
Contributor Author

glopesdev commented Feb 22, 2023 •
edited
Loading

Turns out the loss of precision was due to .NET framework defaults when formatting floating-point numbers to string. This has now been fixed upstream via bonsai-rx/bonsai#1261 so CSV logging should now be reliable.

@glopesdev glopesdev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature New planned feature quality control Data check to ensure integrity or quality of data
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@glopesdev