Ia32 8.7 #44
Closed
Ia32 8.7 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#5: Build for IA32 (x86). I originally was doing this on master but had build issues. I think in hindsight that was due to a problem with MAX_PATH on Windows. So I merged the changes on the 8.7 branch for now. |
|
See issue #42 |
|
FYI this does not fix the path limitation issue - I just was using an older version of V8 that still worked! Thei PR is just to make Win32 builds on MSVC work |
|
I'm going to ahead and close this because we've since upgraded to newer versions. The path issue was fixed in #82 but, caveat emptor, upstream V8 has announced they'll be dropping support for msvc and gcc in September and so will we, in all likelihood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.