🐛 Fixed v8_torque_generated failing to build on Windows #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that
bnoordhuis
reviewed
Mar 4, 2024
|
Nice. This should also help move #66 along, I think? |
|
I think so, but maybe at some point the |
|
Thanks for the pull request, Edgar. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that
Fixes #67
Fixes #42