Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8-cmake fails to build torque #67

Closed
securitydweller opened this issue Jun 22, 2023 · 2 comments · Fixed by #82
Closed

v8-cmake fails to build torque #67

securitydweller opened this issue Jun 22, 2023 · 2 comments · Fixed by #82

Comments

@securitydweller
Copy link

securitydweller commented Jun 22, 2023 •
edited
Loading

Been trying to build torque, however it always fails with The system cannot execute the specified program.

I tried enabling windows long paths and older versions (v.8.9 and v.8.8), still fails.

...
C:/src/out/dev/vendor/v8-cmake/torque-generated/objects-printer-tq.cc C:/src/out/dev/vendor/v8-cmake/torque-generated/objects-printer.cc 
  vendor\v8-cmake\CMakeFiles\aggregate-error-tq-csa.cc-851e72b.bat 617396520723a9cb
  The system cannot execute the specified program.
  
  Batch file failed at line 4 with errorcode 1
  
  ninja: build stopped: subcommand failed.
@bnoordhuis
Copy link
Owner

We hit the same issue on CI while trying to upgrade V8 earlier this week. Cause unclear, unfortunately.

@bnoordhuis bnoordhuis mentioned this issue Jul 19, 2023
Closed
CGQAQ pushed a commit to CGQAQ/v8-cmake that referenced this issue Jul 20, 2023
fix: windows build (bnoordhuis#73,bnoordhuis#67)
1b0498c
@CGQAQ CGQAQ mentioned this issue Jul 20, 2023
Closed
CGQAQ added a commit to CGQAQ/v8-cmake that referenced this issue Jul 28, 2023
@CGQAQ
fix: windows build (bnoordhuis#73,bnoordhuis#67)
24d5d3e
@gengjiawen
Copy link
Collaborator

Been trying to build torque, however it always fails with The system cannot execute the specified program.

I tried enabling windows long paths and older versions (v.8.9 and v.8.8), still fails.

...
C:/src/out/dev/vendor/v8-cmake/torque-generated/objects-printer-tq.cc C:/src/out/dev/vendor/v8-cmake/torque-generated/objects-printer.cc 
  vendor\v8-cmake\CMakeFiles\aggregate-error-tq-csa.cc-851e72b.bat 617396520723a9cb
  The system cannot execute the specified program.
  
  Batch file failed at line 4 with errorcode 1
  
  ninja: build stopped: subcommand failed.

Don't use Ninja on MSVC, it's buggy. default should be fine.

@AnotherFoxGuy AnotherFoxGuy mentioned this issue Mar 3, 2024
Merged
bnoordhuis pushed a commit that referenced this issue Mar 4, 2024
@AnotherFoxGuy
Fix v8_torque_generated failing to build on Windows (#82)
11e1f93 
The torque-outputs and torque_outputs variables can have too many
characters on Windows to be executed on the command line, so we have to
write it to a temporary file and execute that.

Fixes: #42
Fixes: #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bnoordhuis @gengjiawen @securitydweller