Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous Pilatus constructor arg #255

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove extraneous Pilatus constructor arg #255

merged 1 commit into from
Apr 22, 2024

Conversation

DiamondJoseph
Copy link
Contributor

Fixes #254

@DiamondJoseph DiamondJoseph marked this pull request as ready for review April 22, 2024 15:45
callumforrester
callumforrester approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with device_instantiation in dodal?

@DiamondJoseph
Copy link
Contributor Author

Will this work with device_instantiation in dodal?

Yes, the dodal device_instantiation will now call a wrapping DeviceFactoryFunction DLSPilatus (name TBD)

https://github.com/DiamondLightSource/dodal/pull/424/files

@DiamondJoseph DiamondJoseph merged commit f4e7dbb into main Apr 22, 2024
18 checks passed
@DiamondJoseph DiamondJoseph deleted the issue254 branch April 22, 2024 16:01
@callumforrester callumforrester mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester callumforrester approved these changes

@abbiemery abbiemery Awaiting requested review from abbiemery

@coretl coretl Awaiting requested review from coretl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove extraneous prefix from Pilatus constructor
2 participants
@DiamondJoseph @callumforrester