-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pilatus deadtime overridable and add tests #359
Conversation
Is the current Pilatus implementation compatible with a Pilatus2 such that we need to support the current value at all? |
Good question, either way the Pilatus 3 manual doesn't specify a deadtime: https://media.dectris.com/user-manual-pilatus3-2020.pdf It seems to be more detector-dependant. |
Found it:
|
Nevermind then, I can't read |
@coretl Shall we just support the Pilatus 3? |
yes, until someone else asks for an older one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
#: The required minimum time difference between ExpPeriod and ExpTime | ||
#: (readout time) is 2.28 ms | ||
#: We provide an option to override for newer Pilatus models | ||
DEFAULT_READOUT_TIME_SECONDS: float = 2.28e-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFAULT_READOUT_TIME_SECONDS: float = 2.28e-3 | |
class PilatusReadouttime(Enum): | |
"""Pilatus readout time per model in ms""" | |
pilatus2 = 2.28e-3 | |
pilatus3 = 0.95e-3 |
drv_suffix="cam1:", | ||
hdf_suffix="HDF1:", | ||
name="", | ||
readout_time: float = DEFAULT_READOUT_TIME_SECONDS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readout_time: float = DEFAULT_READOUT_TIME_SECONDS, | |
readout_time: PilatusReadoutTime = PilatusReadoutTime.pilatus3, |
4bec3de
to
202ac09
Compare
Fixes #355