Refactor Signal type parsing in pvi logic #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made an attempt to refactor this section of code such that it makes more sense to me, but by definition that makes it opinionated, so see what you think and feel free to make further adjustments.
One thing I wonder is whether to make
_split_subscript
Device-specific and move theassert
in, but I don't think this would make typing the return type any stricter.Fixes #180