Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor type parsing in PVI code #180

Closed
evalott100 opened this issue Apr 9, 2024 · 2 comments · Fixed by #225
Closed

Refactor type parsing in PVI code #180

evalott100 opened this issue Apr 9, 2024 · 2 comments · Fixed by #225
Assignees
@GDYendell
Labels
enhancement New feature or request good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon

Comments

@evalott100
Copy link
Contributor

Depends on #171

Match statements would greatly simplify the type parsing logic in the pvi code introduced in #142
@evalott100 evalott100 added enhancement New feature or request good first issue Good for newcomers labels Apr 9, 2024
@evalott100
Copy link
Contributor Author

ophyd-async/src/ophyd_async/epics/pvi/pvi.py

Lines 161 to 162 in f2ea8c4

# TODO: worth coming back to all this code once 3.9 is gone and we can use
# match statments

@evalott100 evalott100 mentioned this issue Apr 9, 2024
Merged
@evalott100
Copy link
Contributor Author

Probably best to wait on #185 for this.

@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 16, 2024
@GDYendell GDYendell self-assigned this Apr 16, 2024
@GDYendell GDYendell changed the title Use match statments in PVI code Refactor type parsing in PVI code Apr 17, 2024
@GDYendell GDYendell mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GDYendell GDYendell

Labels
enhancement New feature or request good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Hackathon 2024
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Signal type parsing in pvi logic bluesky/ophyd-async
3 participants
@GDYendell @evalott100 @callumforrester