SST fix #474
Closed
SST fix #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed that this needs careful testing and would be likely to break other beamlines (e.g. CSX) if merged, but this at least characterizes the issue well. It may be that the solution is to apply updates at SST. I have been throwing around the term "database migration", but we could alternatively use the new update feature in suitcase-mongo, which seems like a lighter touch. |
|
This should now be implemented as a "transform" and applied to SST configuration. Let's leave this PR open until that has been done. |
|
Closing, moved to here: NSLS-II/nslsii#83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the SST shape, this makes it work for SST, but may break it for other beamlines