Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added transform to fix rsoxs descriptor #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gwbischof
Copy link
Contributor

I tested a bit with real rsoxs data.. until i ran out of RAM.

@gwbischof
Copy link
Contributor Author

Fixes #82

@gwbischof
Copy link
Contributor Author

based on the PR: bluesky/databroker#474 I thought I was going to have to swap the x,y dims. But i was getting shape errors when I did that.

@codecov-io
Copy link

Codecov Report

Merging #83 into master will decrease coverage by 2.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   55.87%   53.39%   -2.48%     
==========================================
  Files          13       13              
  Lines         809      809              
==========================================
- Hits          452      432      -20     
- Misses        357      377      +20     
Impacted Files Coverage Δ
nslsii/tests/temperature_controllers_test.py 66.66% <0.00%> (-33.34%) ⬇️
nslsii/temperature_controllers.py 63.26% <0.00%> (-30.62%) ⬇️
nslsii/_version.py 44.40% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cbe23...aec21d0. Read the comment docs.

@gwbischof
Copy link
Contributor Author

I made the helper functions, because I suspect that other descriptor transforms will use them too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants