Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[External Embeds] Add podcasts to Spotify embeds #5514

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Sep 27, 2024

Fixes #5162

Why

Adding podcasts to embed support for Spotify

Test Plan

Add a Spotify podcast (either a /show/ or /episode/ type url) to a post.

Screenshot 2024-09-26 at 5 51 14 PM

@arcalinea arcalinea temporarily deployed to hailey/spotify-podcast-embeds - social-app PR #5514 September 27, 2024 00:56 — with Render Destroyed
Copy link

Old size New size Diff
9.97 MB 9.97 MB 277 B (0.00%)

@gaearon gaearon merged commit dd2fedb into main Sep 27, 2024
6 checks passed
@gaearon gaearon deleted the hailey/spotify-podcast-embeds branch September 27, 2024 07:19
estrattonbailey added a commit that referenced this pull request Sep 30, 2024
* origin/main:
  Use Inter variable font (#5540)
  Fix name in `feature_request.yml` (#5542)
  Fix sticky offset, gear color (#5537)
  Move email test to root tests dir (#5527)
  revamp issue templates, add new arch template (#5532)
  use PressableScale for animation (#5541)
  Rework native autocomplete (#5521)
  Pinned posts (#5055)
  Remove Segment (#5518)
  Fix alignment of cancel button on search (#5520)
  [Share Extension] Support on Android for sharing videos to app (#5466)
  Ignore bogus onScroll values (#5499)
  add podcasts to spotify embeds (#5514)
  Tweak font size of "Write your reply" (#5513)
  Lazy load ViewShot (#5517)
  [Share Extension] Support images/movies from other apps like iMessage (#5515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify Links to Podcasts is not playing in posts
3 participants