Ignore bogus onScroll values #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/strange-onscroll-values - social-app PR #5499
Render
Destroyed
|
gaearon
approved these changes
Sep 26, 2024
mozzius
force-pushed
the
samuel/strange-onscroll-values
branch
from
9b0711f to
5590139
Compare
gaearon
reviewed
Sep 27, 2024
arcalinea
temporarily deployed
to
samuel/strange-onscroll-values - social-app PR #5499
Render
Destroyed
estrattonbailey
added a commit
that referenced
this pull request
Sep 30, 2024
* origin/main: Use Inter variable font (#5540) Fix name in `feature_request.yml` (#5542) Fix sticky offset, gear color (#5537) Move email test to root tests dir (#5527) revamp issue templates, add new arch template (#5532) use PressableScale for animation (#5541) Rework native autocomplete (#5521) Pinned posts (#5055) Remove Segment (#5518) Fix alignment of cancel button on search (#5520) [Share Extension] Support on Android for sharing videos to app (#5466) Ignore bogus onScroll values (#5499) add podcasts to spotify embeds (#5514) Tweak font size of "Write your reply" (#5513) Lazy load ViewShot (#5517) [Share Extension] Support images/movies from other apps like iMessage (#5515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scroll listener is reporting strange values when the profile first loads (equal to negative header height).
This is a little bit hacky, but it appears safe to ignore those values, since they're typically way out of the range you can possibly achieve by just overscrolling.
Video showing the bogus values:
Screen.Recording.2024-09-26.at.16.17.01.mov