[Experiment] Always show bottom bar #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4946.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqvi22jtq21c73fgos0g. |
gaearon
commented
Aug 16, 2024
| @@ -27,8 +28,13 @@ export function useMinimalShellHeaderTransform() { | |||
| export function useMinimalShellFooterTransform() { | |||
| const mode = useMinimalShellMode() | |||
| const {footerHeight} = useShellLayout() | |||
| const gate = useGate() | |||
| const isFixedBottomBar = gate('fixed_bottom_bar') | |||
There was a problem hiding this comment.
Have to check here because can't do on another thread. It'll have behavior immediately on scroll so seems fine.
|
haileyok
approved these changes
Aug 16, 2024
estrattonbailey
added a commit
that referenced
this pull request
Aug 21, 2024
* origin/main: (50 commits) Add `list hidden` screen (#4958) Expose more methods, support disabled items (#4954) Expose more props from button (#4953) Fix orphaned feed slices, handle blocks (#4944) Tweak `expo-modules-core` hack patch (#4955) [Experiment] Always show bottom bar (#4946) Revert "[Video] Download videos" (#4945) Move global "Sign out" out of the current account row (#4941) Hack patch for testing OTA update crash behavior (#4942) [Video] Download videos (#4886) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where your DMs and notifications are. Let's experiment with always keeping it visible.
Test Plan
No changes outside the gate.
With the gate:
bb.mov
bbandr.mov
bbweb.mov