Fix orphaned feed slices, handle blocks #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4944.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqv842l2ng1s73dfu9o0. |
|
gaearon
reviewed
Aug 16, 2024
gaearon
reviewed
Aug 17, 2024
gaearon
reviewed
Aug 17, 2024
gaearon
approved these changes
Aug 17, 2024
|
Actually should have no effect on main for now, so should be clear to merge this ahead of app view changes |
estrattonbailey
added a commit
that referenced
this pull request
Aug 21, 2024
* origin/main: (50 commits) Add `list hidden` screen (#4958) Expose more methods, support disabled items (#4954) Expose more props from button (#4953) Fix orphaned feed slices, handle blocks (#4944) Tweak `expo-modules-core` hack patch (#4955) [Experiment] Always show bottom bar (#4946) Revert "[Video] Download videos" (#4945) Move global "Sign out" out of the current account row (#4941) Hack patch for testing OTA update crash behavior (#4942) [Video] Download videos (#4886) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on bluesky-social/atproto#2721
Fixes a regression in #4871 where
A -> B -> CandAblocksB, we'd see the entireA -> B -> Cthread, whereas the intention was to filter out those "orphaned" threads. If we want to show orphaned threads, it's a one-line change infeed-tuners.Testing
Test the scenarios below using the backend PR. Otherwise test prod, nothing should look different using prod data. Only the backend PR sends down data needed to compute the correct view.
Blocks
AblocksB, orBblocksA. Viewing asC.See in prod, thread is orphaned (and technically "Reply to test.esb.lol" should say "Reply to blocked post")
In main, you can see through the 3p blocks:
In this PR,
Conly seesAbecause the thread view would otherwise be "orphaned"CblocksA. Viewing asCIn all cases the entire feed slice is filtered out 👍
CblocksB. Viewing asC.In all cases, only
Ais visible 👍Not found posts
In case of
Bdeleting their post, again onlyAis visible in feeds, and when viewingCauthor feed, this PR now notes that the post was removed with the following:I chose "unknown post" instead of "deleted post" because there are multiple reasons a post might be "not found".