Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old onboarding #4224

Merged
merged 5 commits into from
May 28, 2024
Merged

Remove old onboarding #4224

merged 5 commits into from
May 28, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented May 26, 2024

Removes old onboarding including state and logic that becomes dead code with the v2 flag.

Test Plan

Create an account. It works.

Copy link

render bot commented May 26, 2024

Copy link

github-actions bot commented May 26, 2024

Old size New size Diff
7.27 MB 7.27 MB -408 B (-0.01%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, making an account works fine.

@gaearon gaearon force-pushed the flip-onboarding branch from 8d4f9bd to 9e3cc8c Compare May 28, 2024 15:46
@gaearon gaearon merged commit adbbded into main May 28, 2024
6 checks passed
@gaearon gaearon deleted the flip-onboarding branch May 28, 2024 15:56
estrattonbailey added a commit that referenced this pull request May 28, 2024
* origin/main: (392 commits)
  Remove old onboarding (#4224)
  Replace getAgent() with reading agent (#4243)
  Bump 1.85.0 (#4237)
  bump iOS target to `14.0` (#4238)
  set `onEndReachedThreshold` to `2` for notifications (#4235)
  Run intl extract (#4217)
  Updated Japanese translation (#4144)
  Updated Chinese translation (#4147)
  Update Korean localization (#4148)
  Update catalan messages.po (#4149)
  Update Indonesian translation (#4165)
  [🐴] update convo list from message bus (#4189)
  Recover from initial failed firehose state (#4211)
  Move ALT indicator right and shrink it a bit (#4213)
  Make sure failed messages enter error state (#4210)
  [🐴] Don't submit the message on return press when on a phone (web input) (#4203)
  Include feedContext in DOM as data- (#4206)
  Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677)
  Privileged app passwords (#4200)
  [🐴] Overfetch follow for default new dialog state (#4205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants