Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ALT indicator right and shrink it a bit #4213

Merged
merged 1 commit into from
May 24, 2024
Merged

Move ALT indicator right and shrink it a bit #4213

merged 1 commit into from
May 24, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented May 24, 2024

The ALT text indicator has a habit of covering text inside of images, which is pretty irritating and counter-productive for an a11y feature. This PR moves the ALT indicator from the left to the right and shrinks it, hopefully reducing the likelyhood that it'll cover content.

Before After
CleanShot 2024-05-24 at 10 31 32@2x CleanShot 2024-05-24 at 10 30 13@2x
CleanShot 2024-05-24 at 10 32 24@2x CleanShot 2024-05-24 at 10 30 26@2x
CleanShot 2024-05-24 at 10 32 43@2x CleanShot 2024-05-24 at 10 30 35@2x
CleanShot 2024-05-24 at 10 32 58@2x CleanShot 2024-05-24 at 10 30 44@2x
CleanShot 2024-05-24 at 10 33 13@2x CleanShot 2024-05-24 at 10 30 58@2x

Copy link

render bot commented May 24, 2024

Copy link

Old size New size Diff
7.3 MB 7.3 MB 0 B (0.00%)

@pfrazee pfrazee merged commit afab4d5 into main May 24, 2024
6 checks passed
@pfrazee pfrazee deleted the paul/move-alt branch May 24, 2024 18:24
estrattonbailey added a commit that referenced this pull request May 28, 2024
* origin/main: (392 commits)
  Remove old onboarding (#4224)
  Replace getAgent() with reading agent (#4243)
  Bump 1.85.0 (#4237)
  bump iOS target to `14.0` (#4238)
  set `onEndReachedThreshold` to `2` for notifications (#4235)
  Run intl extract (#4217)
  Updated Japanese translation (#4144)
  Updated Chinese translation (#4147)
  Update Korean localization (#4148)
  Update catalan messages.po (#4149)
  Update Indonesian translation (#4165)
  [🐴] update convo list from message bus (#4189)
  Recover from initial failed firehose state (#4211)
  Move ALT indicator right and shrink it a bit (#4213)
  Make sure failed messages enter error state (#4210)
  [🐴] Don't submit the message on return press when on a phone (web input) (#4203)
  Include feedContext in DOM as data- (#4206)
  Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677)
  Privileged app passwords (#4200)
  [🐴] Overfetch follow for default new dialog state (#4205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants