Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zh-TW #3960

Closed
wants to merge 0 commits into from
Closed

Update zh-TW #3960

wants to merge 0 commits into from

Conversation

KuwaLee
Copy link
Contributor

@KuwaLee KuwaLee commented May 11, 2024 •
edited
Loading

Please help me review @auroursa

auroursa
auroursa reviewed May 11, 2024
View reviewed changes
Copy link
Contributor

@auroursa auroursa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned before, I'm not sure if running intl:extract manually is necessary
Other than that, LGTM

@KuwaLee KuwaLee marked this pull request as draft May 11, 2024 04:47
@KuwaLee KuwaLee marked this pull request as ready for review May 11, 2024 05:01
cirx1e
cirx1e reviewed May 11, 2024
View reviewed changes
Copy link
Contributor

@cirx1e cirx1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正了一些用詞

src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
src/locale/locales/zh-TW/messages.po Outdated Show resolved Hide resolved
@cirx1e
Copy link
Contributor

cirx1e commented May 11, 2024 •
edited
Loading

It's a bit awkward because I just made changes here... If 「使用者」 is more commonly used, I'll roll back the changes.
The previous translation mixed 「用戶」 and 「使用者」, so this time I just wanted to make the translation more consistent.

Originally posted in #3678 (comment)

接續之前的討論，臺灣應較常把 "user" 譯為「使用者」？
沒有異議的話，建議把「用戶」統一替換成「使用者」

@KuwaLee 你的看法？

Twitter

Screenshot_20240512_010000_X

Source: Twitter 帳戶設定

Mastodon

bb9fc66e-0ec1-4627-92d8-da8ceecc9cef

Source: Mastodon 註冊頁面

Google

835f8d37-ec26-4143-b0d8-03a2785798ea

Source: Google 建立帳號頁面

@KuwaLee
Copy link
Contributor Author

KuwaLee commented May 11, 2024 •
edited
Loading

@cirx1e 之前討論過在這份翻譯中用戶指有帳號之user，沒有帳號的user是使用者
#3678 (comment)

@pfrazee
Copy link
Collaborator

pfrazee commented May 14, 2024

How's this looking? Good to merge?

@KuwaLee KuwaLee closed this May 15, 2024
@KuwaLee KuwaLee mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirx1e cirx1e cirx1e left review comments

@a681120g a681120g a681120g left review comments

@auroursa auroursa auroursa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KuwaLee @cirx1e @pfrazee @auroursa @a681120g