Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification localization #3911

Conversation

quiple
Copy link
Contributor

@quiple quiple commented May 8, 2024

  • Makes it easier to localize by providing full context.
#: src/view/com/notifications/FeedItem.tsx:173
#~ msgid "followed you"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:195
#~ msgid "followed you back"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:176
#~ msgid "liked your custom feed"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:168
#~ msgid "liked your post"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:170
#~ msgid "reposted your post"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:197
#~ msgid "signed up with your starter pack"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:261
#~ msgid "{0, plural, one {{formattedCount} other} other {{formattedCount} others}}"
#~ msgstr ""

#: src/view/com/notifications/FeedItem.tsx:288
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} followed you"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:262
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} followed you back"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:316
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} liked your custom feed"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:205
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} liked your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:231
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} reposted your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:342
msgid "{a11yAuthor} and {0, plural, one {{formattedCount} other} other {{formattedCount} others}} signed up with your starter pack"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:293
msgid "{a11yAuthor} followed you"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:267
msgid "{a11yAuthor} followed you back"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:321
msgid "{a11yAuthor} liked your custom feed"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:210
msgid "{a11yAuthor} liked your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:236
msgid "{a11yAuthor} reposted your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:347
msgid "{a11yAuthor} signed up with your starter pack"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:296
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> followed you"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:270
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> followed you back"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:324
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> liked your custom feed"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:213
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> liked your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:239
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> reposted your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:350
msgid "{author} and <0>{0, plural, one {{formattedCount} other} other {{formattedCount} others}}</0> signed up with your starter pack"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:308
msgid "{author} followed you"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:282
msgid "{author} followed you back"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:336
msgid "{author} liked your custom feed"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:225
msgid "{author} liked your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:251
msgid "{author} reposted your post"
msgstr ""

#: src/view/com/notifications/FeedItem.tsx:362
msgid "{author} signed up with your starter pack"
msgstr ""

Tested on the web.

@quiple
Copy link
Contributor Author

quiple commented Jun 10, 2024

@pfrazee Hello, could you please review this PR?

@quiple quiple force-pushed the Improve-notification-localization branch from 42b00eb to d0a2e26 Compare July 8, 2024 02:38
@haileyok haileyok self-requested a review July 12, 2024 01:57
@haileyok
Copy link
Contributor

Pretty nasty merge conflict here, from fixing RTL support. I can look later and clean it up unless you really feel a desire to do it 😅

@quiple
Copy link
Contributor Author

quiple commented Jul 12, 2024

@haileyok I think it's probably done. Thanks for notice!

@quiple
Copy link
Contributor Author

quiple commented Jul 26, 2024

@haileyok Can you please review this PR and also #3912?

…ification-localization"

This reverts commit f435d1e, reversing
changes made to dae2aee.
@quiple
Copy link
Contributor Author

quiple commented Sep 25, 2024

@estrattonbailey Hello, I was wondering if you could review this PR?

@estrattonbailey estrattonbailey changed the base branch from main to noty-i18n October 1, 2024 14:59
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for all your work on this, we really appreciate it! Gonna merge into a base branch and test from there 👍

@estrattonbailey estrattonbailey merged commit 85491e2 into bluesky-social:noty-i18n Oct 1, 2024
6 checks passed
@quiple quiple deleted the Improve-notification-localization branch October 8, 2024 00:09
estrattonbailey added a commit that referenced this pull request Oct 31, 2024
* Improve notification localization (#3911)

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update PostMeta.tsx

* Update RightNav.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* a11y

* Update FeedItem.tsx

* Update PostThreadItem.tsx

* Update PostThreadItem.tsx

* revert

* Update FeedItem.tsx

* Update FeedItem.tsx

* Update FeedItem.tsx

* Revert "Merge remote-tracking branch 'upstream/main' into Improve-notification-localization"

This reverts commit f435d1e, reversing
changes made to dae2aee.

* Reapply "Merge remote-tracking branch 'upstream/main' into Improve-notification-localization"

This reverts commit c93ac19.

* Update ThreadgateBtn.tsx

* Rm import edits for now

* Cleanups

---------

Co-authored-by: Minseo Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants