-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve notification localization #3911
Improve notification localization #3911
Conversation
@pfrazee Hello, could you please review this PR? |
42b00eb
to
d0a2e26
Compare
Pretty nasty merge conflict here, from fixing RTL support. I can look later and clean it up unless you really feel a desire to do it 😅 |
@haileyok I think it's probably done. Thanks for notice! |
…tification-localization" This reverts commit c93ac19.
@estrattonbailey Hello, I was wondering if you could review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for all your work on this, we really appreciate it! Gonna merge into a base branch and test from there 👍
* Improve notification localization (#3911) * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Update PostMeta.tsx * Update RightNav.tsx * Update FeedItem.tsx * Update FeedItem.tsx * a11y * Update FeedItem.tsx * Update PostThreadItem.tsx * Update PostThreadItem.tsx * revert * Update FeedItem.tsx * Update FeedItem.tsx * Update FeedItem.tsx * Revert "Merge remote-tracking branch 'upstream/main' into Improve-notification-localization" This reverts commit f435d1e, reversing changes made to dae2aee. * Reapply "Merge remote-tracking branch 'upstream/main' into Improve-notification-localization" This reverts commit c93ac19. * Update ThreadgateBtn.tsx * Rm import edits for now * Cleanups --------- Co-authored-by: Minseo Lee <[email protected]>
Tested on the web.