Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to interface strings to support more languages #3481

Closed
Aonghuso opened this issue Apr 11, 2024 · 4 comments · Fixed by #6668
Closed

Add variables to interface strings to support more languages #3481

Aonghuso opened this issue Apr 11, 2024 · 4 comments · Fixed by #6668
Labels
feature-request A request for a new feature

Comments

@Aonghuso
Copy link

Irish has recently been added as an interface language. However, because Irish has verb subject object word order, some of the translations are awkward or just plain wrong because parts of the string are not parts of the message string.

For example
#: src/view/com/notifications/FeedItem.tsx:170
msgid "liked your custom feed"
msgstr "a mhol do shainfhotha"

#: src/view/com/notifications/FeedItem.tsx:155
msgid "liked your post"
msgstr "a mhol do phostáil"

The subject is not part of the the string to be localised.

This leads to "X a mhol do phostáil"

But the idiomatic way to say this would be Mhol X do phostáil.

Using a placeholder for the subject would permit this.

@Aonghuso Aonghuso added the feature-request A request for a new feature label Apr 11, 2024
@kscanne
Copy link
Contributor

kscanne commented Apr 11, 2024

As one of the contributors to the Irish localization, I can confirm that this is a significant problem. There is no way of rephrasing the translation to make it not completely awkward/ungrammatical.

@quiple
Copy link
Contributor

quiple commented Jun 12, 2024

PRs related to this issue: #3911, #3912, #3948, #4494

@kscanne
Copy link
Contributor

kscanne commented Nov 18, 2024

This appears to be fixed in release 1.94; we now have the variables we need to provide correct translations. Thanks to whoever handled this!

@surfdude29
Copy link
Contributor

Thanks to whoever handled this!

Credit to @quiple and @estrattonbailey for fixing this in #5550 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants