Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{labelTarget}, {els} won't work cross-linguistically #3660

Closed
kscanne opened this issue Apr 23, 2024 · 0 comments · Fixed by #3912
Closed

{labelTarget}, {els} won't work cross-linguistically #3660

kscanne opened this issue Apr 23, 2024 · 0 comments · Fixed by #3912
Labels
bug Something isn't working

Comments

@kscanne
Copy link
Contributor

kscanne commented Apr 23, 2024

There are a couple of localizable strings that use the variable {labelTarget}. Browsing the code, it looks like this can only take the values which are the localized versions of "account" or "content". This won't work for Irish since the localizations of those words would need to change based on the wider context.

The general i18n principle is to avoid "sentence puzzles" like this where variables get plugged in from other localized strings, since they are sure to fail for some language. Better to just offer separate strings for localization:

"label has been placed on this account"
"label has been placed on this content"

(NB this is in contrast with the need for more variables in the case of unlocalizable content like usernames, hashtags, URLs, etc.; cf Issue #3481)

Same issue with {els} in the string: "By creating an account you agree to the {els}."
Especially so given that (if I understand correctly), the value plugged into {els} could be either singular (a Privacy Policy) or plural (the Terms of Service).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant