Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean localization #2432

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Conversation

quiple
Copy link
Contributor

@quiple quiple commented Jan 5, 2024

Fixed some existing translations and translated newly updated strings from version 1.63.

Thanks!

@HaruChanHeart
Copy link

I just checked the translation, and there's no big problem, but I think we need a better translation here.

It looks better to say 피드 끝에 도달했습니다! as 마지막 피드까지 도착했습니다!

If you want, I can review it and help you with the translation.

@quiple
Copy link
Contributor Author

quiple commented Jan 6, 2024

I just checked the translation, and there's no big problem, but I think we need a better translation here.

It looks better to say 피드 끝에 도달했습니다! as 마지막 피드까지 도착했습니다!

If you want, I can review it and help you with the translation.

I think replacing "피드 끝" with "마지막 피드" seems undesirable because it completely changes the meaning (피드가 마지막인 것이 아니기 때문에), and "도달" and "도착" are practically synonymous and don't seem to make much difference, so I don't see the need to change them.

And best of all, that part is not currently marked for translation in version 1.63, so I don't think it matters much at this point. I'm just adding it for when it's later marked for translation.

Thanks!

@HaruChanHeart
Copy link

I think replacing "피드 끝" with "마지막 피드" seems undesirable because it completely changes the meaning (피드가 마지막인 것이 아니기 때문에), and "도달" and "도착" are practically synonymous and don't seem to make much difference, so I don't see the need to change them.

And best of all, that part is not currently marked for translation in version 1.63, so I don't think it matters much at this point. I'm just adding it for when it's later marked for translation.

Thanks for commenting! I have a few more questions.

I think the sentence 이 도메인에 레코드가 추가됩니다 is explained in a confusing way. It seems meaning "This domain will add these records" (이 도메인에 다음 레코드들이 추가됩니다).

So, 도메인 레코드들을 다음과 같이 추가해 주십시오 seems more appropriate.

#: src/view/screens/Settings.tsx:803
msgid "Verify email"
msgstr "이메일 확인"

#: src/view/screens/Settings.tsx:842
msgid "Protect your account by verifying your email."
msgstr "이메일을 인증하여 계정을 보호하세요."

And 이메일 확인 is would be better to change it to 이메일 인증 for unification with other sentences.

@quiple
Copy link
Contributor Author

quiple commented Jan 7, 2024

Thanks for commenting! I have a few more questions.

I think the sentence 이 도메인에 레코드가 추가됩니다 is explained in a confusing way. It seems meaning "This domain will add these records" (이 도메인에 다음 레코드들이 추가됩니다).

So, 도메인 레코드들을 다음과 같이 추가해 주십시오 seems more appropriate.

#: src/view/screens/Settings.tsx:803
msgid "Verify email"
msgstr "이메일 확인"

#: src/view/screens/Settings.tsx:842
msgid "Protect your account by verifying your email."
msgstr "이메일을 인증하여 계정을 보호하세요."

And 이메일 확인 is would be better to change it to 이메일 인증 for unification with other sentences.

Thanks for the review! I've updated all the 확인 related to email verification to 인증.

And the sentence 이 도메인에 레코드가 추가됩니다 is not a description of the DNS record, but rather a description of the domain to which the record will be added.

스크린샷 2024-01-07 12 05 46

This will localized as this:

스크린샷 2024-01-07 12 05 20

@HaruChanHeart
Copy link

And the sentence 이 도메인에 레코드가 추가됩니다 is not a description of the DNS record, but rather a description of the domain to which the record will be added.

Aha, sorry for misunderstanding :(

Now it doesn't seem like a problem anymore! Thank you for translating 👍

Copy link
Contributor

@ansh ansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! @quiple and @HaruChanHeart

@ansh ansh merged commit 15f3c67 into bluesky-social:main Jan 8, 2024
4 checks passed
@pfrazee pfrazee added the intl Internationalization label Jan 8, 2024
estrattonbailey added a commit that referenced this pull request Jan 8, 2024
* origin: (45 commits)
  Fix splash config (#2452)
  convert prefix to lowercase in actor autocomplete query (#2431)
  support intl tenor links (#2438)
  Splash: reduce motion + dark mode (#2448)
  Bump android app version code
  Don't use mask for android at all (#2445)
  Update Korean localization (#2432)
  Use android mode, fix fallback (#2437)
  Update for Version 1.63 Português (BR) (#2435)
  New translations messages.po (Ukrainian) (#2422)
  Update Japanese localization (addition + language code correction) (#2423)
  1.63
  Additional embed sources and external-media consent controls (#2424)
  Reduce web requests (#2420)
  New user home feed fixes (#2421)
  E2E runner fixes (#2428)
  Recompile all locales (#2411) (#2416)
  Add Ukrainian localization (#2336)
  Update Portuguese for Português (#2414)
  Add Portuguese Localization (#2407)
  ...
@quiple quiple deleted the korean-localization branch January 8, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants