Add Ukrainian localization #2336

imax9000 · 2023-12-27T15:07:05Z

No description provided.

ansh · 2023-12-29T17:20:38Z

Great, thanks for the contribution!

I will wait for a bit and see if there are any other Ukrainian users who would like to cross-check this translation. Thanks!

Also, would be great if you pull from main and update the merge conflicts till then

src/locale/locales/uk/messages.po

imax9000 · 2023-12-29T18:08:48Z

Great, thanks for the contribution!

I will wait for a bit and see if there are any other Ukrainian users who would like to cross-check this translation. Thanks!

We've already had a few people going over it on Crowdin.

Also, would be great if you pull from main and update the merge conflicts till then

Will do, give a moment.

src/locale/locales/uk/messages.po

imax9000 · 2023-12-29T18:20:57Z

Also, would be great if you pull from main and update the merge conflicts till then

Done

imax9000 · 2023-12-29T18:49:20Z

Note on the comments w.r.t. localization itself: I started with auto-translation and reviewed and edited all strings in a single pass, with terminology consistency in mind. For the future edits let's please use Crowdin for a couple reasons:

Carrying over the comments from here to there is incredibly annoying and I'm definitely not going to edit .po directly in a text editor.
Preserving context and consistency: once this PR is merged, no one will ever look at it again. But in Crowdin we have the ability to record the decisions regarding terminology as terms, and have them automatically show up whenever a new string that uses them gets added to the source.

Also, I'd much prefer to have this submitted sooner rather than later and send followups with edits later. Because this PR touches a few files that are bottlenecks for merge conflicts, and updating it manually every time line numbers in main change is quite toilsome.

imax9000 · 2024-01-02T14:44:02Z

@ansh updated once more, still up to date with main. Thanks you @ryvwel for adding your suggestions on Crowdin, now most of them are integrated here.

ansh · 2024-01-03T11:35:36Z

@imax9000 Can all the conversations be resolved?

imax9000 · 2024-01-03T12:05:50Z

Yes

imax9000 · 2024-01-03T18:53:31Z

Want me to do another rebase?

ansh · 2024-01-03T19:57:20Z

@imax9000 That would be great!

imax9000 · 2024-01-03T20:22:32Z

@ansh done

* origin: (45 commits) Fix splash config (#2452) convert prefix to lowercase in actor autocomplete query (#2431) support intl tenor links (#2438) Splash: reduce motion + dark mode (#2448) Bump android app version code Don't use mask for android at all (#2445) Update Korean localization (#2432) Use android mode, fix fallback (#2437) Update for Version 1.63 Português (BR) (#2435) New translations messages.po (Ukrainian) (#2422) Update Japanese localization (addition + language code correction) (#2423) 1.63 Additional embed sources and external-media consent controls (#2424) Reduce web requests (#2420) New user home feed fixes (#2421) E2E runner fixes (#2428) Recompile all locales (#2411) (#2416) Add Ukrainian localization (#2336) Update Portuguese for Português (#2414) Add Portuguese Localization (#2407) ...