Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase uri before checking for link #3002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Lowercase uri before checking for link #3002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api/src/rich-text/detection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function detectFacets(text: UnicodeString): Facet[] | undefined {
// links
const re = URL_REGEX
while ((match = re.exec(text.utf16))) {
let uri = match[2]
let uri = match[2].toLowerCase()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will introduce another problem because URI is now manipulated, and it's a return value of this function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point ! I think we can create a separate variable to check if the rawUri is a valid url. If yes, we return the rawUri instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I think we have to be cautious here because this function also manipulates the URI variable. Also, I think we should cover the changes with unit tests.

if (!uri.startsWith('http')) {
const domain = match.groups?.domain
if (!domain || !isValidDomain(domain)) {
Expand Down