Lowercase uri before checking for link #3002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khuddite
reviewed
Nov 14, 2024
| @@ -41,7 +41,7 @@ export function detectFacets(text: UnicodeString): Facet[] | undefined { | |||
| // links | |||
| const re = URL_REGEX | |||
| while ((match = re.exec(text.utf16))) { | |||
| let uri = match[2] | |||
| let uri = match[2].toLowerCase() | |||
There was a problem hiding this comment.
I think it will introduce another problem because URI is now manipulated, and it's a return value of this function.
There was a problem hiding this comment.
Oh good point ! I think we can create a separate variable to check if the rawUri is a valid url. If yes, we return the rawUri instead.
There was a problem hiding this comment.
That makes sense. I think we have to be cautious here because this function also manipulates the URI variable. Also, I think we should cover the changes with unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below method will fail for strings like: Https://google.com, cnn.COM even though these strings should be considered as valid urls. This is also related to an issue from Bluesky social: bluesky-social/social-app#6332